Skip to content

Commit 713b427

Browse files
committed
Replace misleading comment: NVHPC is NOT outdated.
1 parent b9b54a7 commit 713b427

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/pybind11/detail/internals.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,8 @@ struct type_info {
325325
# else
326326
# error "Unknown combination of MSVC preprocessor macros: PLEASE REVISE THIS CODE."
327327
# endif
328-
# elif defined(__NVCOMPILER) // NVHPC (PGI-based, outdated).
329-
# define PYBIND11_BUILD_ABI "" // This was never properly guarded.
328+
# elif defined(__NVCOMPILER) // NVHPC (PGI-based).
329+
# define PYBIND11_BUILD_ABI "" // TODO: What should be here, to prevent UB?
330330
# else
331331
# error "Unknown platform or compiler: PLEASE REVISE THIS CODE."
332332
# endif

0 commit comments

Comments
 (0)