Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out codec from scoring.py and move into separate file #334

Closed
wants to merge 1 commit into from

Conversation

1andrin
Copy link
Contributor

@1andrin 1andrin commented Jan 18, 2025

Problem

scoring.py lacks readability since the Class has large scoring functions directly written into it.

Proposed changes

Move the codec score to a separate file and call the functions from Scoring.

Types of changes

What types of changes does your code introduce to causaltune?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Signed-off-by: 1andrin <115493865+1andrin@users.noreply.github.com>
@1andrin 1andrin closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant