-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Handle inline images containing EI
sequences
#3152
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
==========================================
+ Coverage 96.51% 96.52% +0.01%
==========================================
Files 53 53
Lines 8875 8903 +28
Branches 1622 1631 +9
==========================================
+ Hits 8566 8594 +28
Misses 185 185
Partials 124 124 ☔ View full report in Codecov by Sentry. |
Nice.
Remove spaces around |
Suggestion for amending the comment: Are the C1 control codes needed in the if statement? |
This will fail linting (ruff) as the whitespace is indeed correct here.
Yes, I might update the comment. But I am having some troubles understanding what you mean by C0 and C1 control codes - what are you referring to? |
Thanks for the link. I am not completely sure about this, but as the value |
## What's new ### Bug Fixes (BUG) - Use the correct name StandardEncoding for the predefined cmap (#3156) by @stefan6419846 - Handle inline images containing `EI ` sequences (#3152) by @stefan6419846 - Fix check box value which should be name object (#3124) by @stefan6419846 - Fix stream position on inline image fallback extraction (#3120) by @stefan6419846 - Fix object count for incremental writer (#3117) by @m32 ### Robustness (ROB) - Avoid index errors on empty lines in xref table (#3162) by @stefan6419846 - Improve handling of LZW decoder table overflow (#3159) by @stefan6419846 - Ignore non-numbers for width when building font width map (#3158) by @stefan6419846 - Avoid negative seek values when reading partially broken files (#3157) by @stefan6419846 ### Documentation (DOC) - Fixed PageObject.images example usage for replacing image (#3149) by @jutoth [Full Changelog](5.3.0...5.3.1)
Closes #3107.