-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and CI updates #129
Test and CI updates #129
Conversation
…oved from pandas in a future version. Use pandas.concat instead.
Ok, ready for review. A bit of context for the last commit: bfc9390 fixes an issue with scipy v1.8.0 (released Feb 5, 2022), which includes a change where pvanalytics/pvanalytics/util/_fit.py Lines 66 to 68 in 6fb4c87
However, switching to the correct parameter order doesn't get all the tests passing: |
OK to merge when the whatsnew conflict is resolved. |
Build fails after merging #127. But it appears the failures will be fixed with this PR. |
Tests here are green, so I expect so. |
Description
This PR:
pvlib<0.9.0
down the line.Because this PR doesn't add any new tests using multiple Arrays, it only partially addresses #116.
Checklist
[ ] Closes #xxx[ ] Added new API functions todocs/api.rst
[ ] Clearly documented all new API functions with PEP257 and numpydoc compliant docstringsin
docs/whatsnew
for all changes. Includes link to the GitHub Issue with
:issue:`num`
or this Pull Request with
:pull:`num`
. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`
).[ ] Non-API functions clearly documented with docstrings or comments as necessary[ ] Added tests to cover all new or modified code