Make cache and values fully thread-safe #8951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not locking the default initialization can lead to race-conditions. Note: not sure if I should use one or two mutexes as I am not familiar with this code enough to make the judgment. ref: ruby-concurrency/concurrent-ruby#970
|
Can one of the admins verify this patch? |
|
|
joshcooper
requested changes
Nov 15, 2023
There was a problem hiding this comment.
@mensfeld thanks for letting us know! Is the recommended pattern now to use compute_if_absent?
@cache = Concurrent::Hash.new do |hash, key|
hash.compute_if_absent(key) { Concurrent::Hash.new }
end
|
@joshcooper if you want it to be thread-safe yes. |
|
@mensfeld could you update your PR to call |
|
@joshcooper not really. This PR is one year old. Feel free to close and apply the PR alongside other changes or ignore. Sorry but I no longer have puppet setup on my machine 🙏 |
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Nov 16, 2023
Not locking the default initialization can lead to race-conditions. ref: ruby-concurrency/concurrent-ruby#970 Co-authored-by: Maciej Mensfeld <maciej@mensfeld.pl> resolves puppetlabs#8951
|
I added a new PR and added you as an author. Thanks for telling us about this issue! |
joshcooper
added a commit
to joshcooper/puppet
that referenced
this pull request
Nov 16, 2023
Not locking the default initialization can lead to race-conditions. I don't think we can switch to Concurrent::Map, and it's compute_if_absent method, because insertion order won't be maintained. So synchronize the long way. ref: ruby-concurrency/concurrent-ruby#970 Co-authored-by: Maciej Mensfeld <maciej@mensfeld.pl> resolves puppetlabs#8951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not locking the default initialization can lead to race-conditions.
Note: not sure if I should use one or two mutexes as I am not familiar with this code enough to make the judgment.
ref: ruby-concurrency/concurrent-ruby#970