Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RE-16550): Debian 12 bookworm FOSS build target #629

Merged
merged 3 commits into from
Aug 26, 2024
Merged

(RE-16550): Debian 12 bookworm FOSS build target #629

merged 3 commits into from
Aug 26, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Apr 21, 2024

No description provided.

h0tw1r3 added 3 commits April 20, 2024 12:23
@h0tw1r3
(maint) drop platform 6 fpm support
a7c9eba
@h0tw1r3
(maint) debian platforms simplify java depends
8451c73 
possible to install java 17 and java 11, package should be flexible
to accept either as a dependency
@h0tw1r3
(maint) add Debian 12 bookworm as a FOSS build target
4e485d8
@h0tw1r3 h0tw1r3 requested review from a team as code owners April 21, 2024 16:31
@h0tw1r3 h0tw1r3 mentioned this pull request May 5, 2024
Merged
@h0tw1r3 h0tw1r3 mentioned this pull request May 30, 2024
Open
smortex
smortex approved these changes May 31, 2024
View reviewed changes
Copy link

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me wants Debian 12 packages for puppetserver and puppetdb 😭

Approving, even if my approval will probably not help at all 😢

@kenyon
Copy link

kenyon commented Jun 7, 2024

Typo in PR title: Debain -> Debian

@h0tw1r3 h0tw1r3 changed the title Debain 12 bookworm FOSS build target Debian 12 bookworm FOSS build target Jun 7, 2024
@joshcooper
Copy link
Contributor

@h0tw1r3 could you rebase and resolve conflicts?

@span786
Copy link
Contributor

span786 commented Aug 23, 2024

@puppetlabs/release-engineering / @puppetlabs/dumpling / @puppetlabs/skeletor
I successfully generated the lein-ezbake JAR using the changes from this PR: lein-ezbake-2.6.2.jar.zip. However, there isn't an ad-hoc Jenkins pipeline available to test if the JAR is functioning correctly. Can we merge this PR and test it in the main pipeline here?

@span786 span786 changed the title Debian 12 bookworm FOSS build target (RE-16550): Debian 12 bookworm FOSS build target Aug 23, 2024
@bastelfreak
Copy link

All our lives would be easier if the pipelines would be public again, at least for the Vox Pupuli PMC and Puppet Partners.

@justinstoller
Copy link
Member

I believe the practice before was to build a puppetserver and/or puppetdb package using the changes in a PR and then ensure they install on the target system. Once that is manually tested, ideally by both the PR author and reviewer, then the PR can be merged and a new ezbake released by the pipeline you linked, @span786 .

And Tim is also correct.

@justinstoller
Copy link
Member

Here is a lightly edited log of me validating this PR as an example: ezbake.log

@span786 span786 merged commit a240167 into puppetlabs:main Aug 26, 2024
3 checks passed
This was referenced Sep 2, 2024
Merged
Merged
@h0tw1r3 h0tw1r3 deleted the debian12 branch October 3, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@justinstoller justinstoller justinstoller approved these changes

@tuxmea tuxmea tuxmea approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@h0tw1r3 @kenyon @joshcooper @span786 @bastelfreak @justinstoller @smortex @tuxmea