Support creating a projected target PSF #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 51.24% 51.24%
=======================================
Files 12 12
Lines 921 921
=======================================
Hits 472 472
Misses 449 449 ☔ View full report in Codecov by Sentry. |
jmbhughes
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a forward PSF that, instead of regularizing each star to an unvarying circular shape, regularizes to the shape that a true circular star would take in that portion of the image according to the image's projection. This should ensure that as we go forward to mosaic building and starfield estimation and subtraction, each star ends up with the correct shape no matter where in the image plane it's being observed.
The difference is subtle, but there:
