Replace snitch_icache with cluster_icache dependency #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micprog
requested review from
paulsc96,
SamuelRiedel,
colluca and
fischeti
as code owners
fischeti
approved these changes
Mar 12, 2024
|
Thanks @micprog! LGTM, only thing I would change concerns the CI fix. Since pulp-platform/common_cells#217 was merged to master already, I would temporarily use that hash in the Let me know what you think, I can implement the remaining changes and merge. |
|
I think waiting shortly for the common_cells release would make sense to keep consistency and maximum testability. Separating the CI fixes from this PR would also be valuable as a separation of concerns. |
colluca
force-pushed
the
michaero/icache_dep
branch
from
b5e7a29 to
0dff824
Compare
colluca
force-pushed
the
michaero/icache_dep
branch
from
0dff824 to
fe855aa
Compare
colluca
approved these changes
Mar 18, 2024
SamuelRiedel
approved these changes
Mar 18, 2024
colluca
pushed a commit
that referenced
this pull request
Apr 15, 2024
colluca
pushed a commit
that referenced
this pull request
Apr 15, 2024
colluca
pushed a commit
that referenced
this pull request
Apr 15, 2024
colluca
pushed a commit
that referenced
this pull request
Apr 15, 2024
colluca
pushed a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep a single common source for IPs, the snitch_cluster instruction cache was extracted into its own repository. This repository was updated with features from Mempool, allowing reuse of common features, improvements, and bugfixes. This PR updates the icache to point to this new common source through a bender dependency.