Attempt to fix login for docker

pufferpanel · Jan 8, 2024 · 5d45ca6 · 5d45ca6
1 parent cb66315
commit 5d45ca6
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -42,12 +42,11 @@ jobs:
         uses: docker/setup-buildx-action@v3
 
       - name: Login to DockerHub
-        if: ${{ env.REGISTRY_USERNAME != '' }}
         uses: docker/login-action@v3
         with:
-          registry: ${{ env.REGISTRY }}
-          username: ${{ env.REGISTRY_USERNAME }}
-          password: ${{ env.REGISTRY_PASSWORD }}
+          registry: ${{ vars.REGISTRY }}
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
 
       - name: Extract Docker metadata
         id: meta
@@ -68,7 +67,7 @@ jobs:
         with:
           context: .
           file: ${{ matrix.file }}
-          push: ${{ github.event_name != 'pull_request' && env.REGISTRY_USERNAME != '' }}
+          push: ${{ github.event_name != 'pull_request' }}
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
           cache-from: type=gha