Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add emailaddress to zone on create #67

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

b12f
Copy link
Member

@b12f b12f commented Jul 18, 2024

No description provided.

Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the integration tests!

@@ -52,6 +52,13 @@ resource "hostingde_record" "test_mx" {
content = "mail.example2.test"
priority = 10
}
resource "hostingde_record" "test_mx" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate of the above test resource. make testacc passes for me without this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, removed it

@b12f b12f merged commit 0424cb9 into main Aug 13, 2024
1 check passed
@b12f b12f deleted the fix/ttl-check-zone-email-create branch August 13, 2024 09:18
@b12f b12f restored the fix/ttl-check-zone-email-create branch August 13, 2024 09:19
@teutat3s teutat3s deleted the fix/ttl-check-zone-email-create branch August 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants