Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round End Credits #439

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Conversation

RengaN02
Copy link
Contributor

@RengaN02 RengaN02 commented Jan 31, 2025

Pull Request Hakkında

Ports Round End Credits from Monkestation/Monkestation2.0#3301

Oyunun sonuna credits ekler.
Creditsin başlığı turda olan bir olaya göre değişir. Örnek olarak tur sonunda kimse ölü değilse onunla alakalı bir başlık yazar.

2025-01-31.22-30-19.1.2.mp4

Oyun İçin Neden Gerekli

Oyunun sonunda oyunda yaşanan şeylerin sanki bir filmmiş ve bitmiş gibi olması, oyuncularda filmin oyuncuları gibi gösterilmesi bence hoş duruyor. Bu yüzden oyuna eklemek istedim.

Changelog

🆑 Rengan
add: Round Ende Credits eklendi, eğer görmek istesemezseniz Game Preferences > UI > Show Roundend Credits tikini kapatabilirsiniz.
/:cl:

@RengaN02 RengaN02 requested a review from Seefaaa as a code owner January 31, 2025 20:33
@RengaN02 RengaN02 marked this pull request as draft February 2, 2025 19:36
@RengaN02 RengaN02 marked this pull request as ready for review February 3, 2025 14:54
Copy link
Contributor

@Seefaaa Seefaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patreon üyelerinin ve adminlerin save dosyalarını okumadan önce oyunda olup olmadıklarını kontrol etmen daha uygun olur gibi.
eğer dummy'yi oluşturmak için char_preview zorunlu değilse gereksiz kullanım olmuş gibi yalnızca mutable_appearance yeterli görünüyor.
maptext'te kullandığın classlar bir şey ifade ediyor mu ben bilmiyorum
çok iterasyon ve uzun sürebilecek proclar var bunların lag yapmaması için asenkron yapıp CHECK_TICK kullanmalısın

@RengaN02
Copy link
Contributor Author

son halinin videosunu atar mısın

2025-02-12.21-58-22.1.mp4

@RengaN02
Copy link
Contributor Author

videoyu sıkıştırdıgım icin kötü gözüküyo biraz

@RengaN02 RengaN02 requested a review from Seefaaa February 12, 2025 19:57
Copy link
Contributor

github-actions bot commented Feb 12, 2025

This pull request was test merged in 90 round(s).

Round list
  • 7125 @ 2025-02-22 02:36:28
  • 7124 @ 2025-02-22 00:12:27
  • 7123 @ 2025-02-22 00:06:00
  • 7122 @ 2025-02-21 23:58:26
  • 7121 @ 2025-02-21 22:39:17
  • 7120 @ 2025-02-21 20:14:09
  • 7119 @ 2025-02-21 17:51:47
  • 7118 @ 2025-02-21 15:30:57
  • 7117 @ 2025-02-21 12:24:09
  • 7116 @ 2025-02-21 09:52:11
  • 7115 @ 2025-02-21 03:44:23
  • 7114 @ 2025-02-21 02:02:50
  • 7113 @ 2025-02-20 23:40:40
  • 7112 @ 2025-02-20 23:31:59
  • 7111 @ 2025-02-20 22:15:01
  • 7110 @ 2025-02-20 22:07:14
  • 7109 @ 2025-02-20 19:45:59
  • 7108 @ 2025-02-20 17:42:04
  • 7107 @ 2025-02-20 15:52:33
  • 7106 @ 2025-02-20 12:23:15
  • 7105 @ 2025-02-20 09:11:46
  • 7104 @ 2025-02-20 05:01:00
  • 7103 @ 2025-02-20 01:20:07
  • 7102 @ 2025-02-19 23:56:49
  • 7101 @ 2025-02-19 21:39:30
  • 7100 @ 2025-02-19 19:13:50
  • 7099 @ 2025-02-19 19:05:35
  • 7098 @ 2025-02-19 15:23:13
  • 7097 @ 2025-02-19 11:41:32
  • 7096 @ 2025-02-19 10:44:21
  • 7095 @ 2025-02-19 07:59:58
  • 7094 @ 2025-02-19 04:14:57
  • 7093 @ 2025-02-19 01:17:27
  • 7092 @ 2025-02-18 22:50:34
  • 7091 @ 2025-02-18 22:41:04
  • 7090 @ 2025-02-18 21:04:40
  • 7089 @ 2025-02-18 20:25:32
  • 7088 @ 2025-02-18 17:28:33
  • 7087 @ 2025-02-18 13:07:07
  • 7086 @ 2025-02-18 05:20:34
  • 7085 @ 2025-02-18 02:02:33
  • 7084 @ 2025-02-17 23:54:30
  • 7083 @ 2025-02-17 22:41:53
  • 7082 @ 2025-02-17 21:02:27
  • 7081 @ 2025-02-17 20:58:40
  • 7080 @ 2025-02-17 17:43:40
  • 7079 @ 2025-02-17 08:42:18
  • 7078 @ 2025-02-17 06:10:16
  • 7077 @ 2025-02-17 01:33:40
  • 7076 @ 2025-02-16 23:19:47
  • 7075 @ 2025-02-16 23:15:02
  • 7074 @ 2025-02-16 21:19:56
  • 7073 @ 2025-02-16 19:37:05
  • 7072 @ 2025-02-16 17:27:39
  • 7071 @ 2025-02-16 15:09:31
  • 7070 @ 2025-02-16 10:37:34
  • 7069 @ 2025-02-16 08:54:07
  • 7068 @ 2025-02-16 04:49:09
  • 7067 @ 2025-02-16 01:46:56
  • 7066 @ 2025-02-15 23:19:28
  • 7065 @ 2025-02-15 21:51:35
  • 7064 @ 2025-02-15 20:41:42
  • 7062 @ 2025-02-15 18:25:13
  • 7061 @ 2025-02-15 15:47:29
  • 7060 @ 2025-02-15 12:03:57
  • 7059 @ 2025-02-15 07:59:31
  • 7058 @ 2025-02-15 07:43:31
  • 7057 @ 2025-02-15 02:30:38
  • 7056 @ 2025-02-15 00:02:59
  • 7055 @ 2025-02-14 21:57:30
  • 7054 @ 2025-02-14 21:51:56
  • 7053 @ 2025-02-14 20:08:13
  • 7052 @ 2025-02-14 18:26:34
  • 7051 @ 2025-02-14 16:58:46
  • 7050 @ 2025-02-14 14:47:47
  • 7049 @ 2025-02-14 11:40:59
  • 7048 @ 2025-02-14 09:30:41
  • 7047 @ 2025-02-14 08:23:05
  • 7046 @ 2025-02-14 07:14:06
  • 7045 @ 2025-02-14 01:19:13
  • 7044 @ 2025-02-13 22:35:41
  • 7043 @ 2025-02-13 20:55:09
  • 7042 @ 2025-02-13 19:01:07
  • 7041 @ 2025-02-13 16:57:00
  • 7040 @ 2025-02-13 16:02:32
  • 7039 @ 2025-02-13 13:56:36
  • 7038 @ 2025-02-13 11:18:16
  • 7037 @ 2025-02-13 04:34:37
  • 7036 @ 2025-02-13 01:33:46
  • 7035 @ 2025-02-13 01:23:58

Copy link
Contributor

@Seefaaa Seefaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mob.real_name kullanmak yerine mind.name kullanmak daha tutarlı olur muhtemelen
ve ölü moblar için last_mind kullanmak gerekebilir belki?

@RengaN02
Copy link
Contributor Author

image

@RengaN02 RengaN02 requested a review from Seefaaa February 17, 2025 22:17
@RengaN02 RengaN02 requested a review from Seefaaa February 19, 2025 10:53
@RengaN02 RengaN02 requested a review from Seefaaa February 21, 2025 14:05
@Seefaaa
Copy link
Contributor

Seefaaa commented Feb 21, 2025

zaten oyunda ise GLOB.preferences_datums'den alabilirsin appearanceyi offline şeyine gerek yok halihazırda oyunda olanlar için

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants