Minor quirk: more straightforward __iter__ impl. for CaseInsensitiveDict #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the actual CaseInsensitiveDict.__iter__ method, both the key and value are extracted but only the key is used. With this minor change we directly loop over the internal dict's keys (which is the default for the dict's __iter__). The difference is minimal, just 4 less bytecode instructions: https://godbolt.org/z/saT7Me3vb (uncomment either __iter__ impl.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the actual
CaseInsensitiveDict.__iter__method, both the key and value are extracted but only the key is used. With this minor change, we would loop directly over the internal dict's keys (which is the default for the dict's__iter__). The difference is minimal, just 4 less bytecode instructions: https://godbolt.org/z/saT7Me3vb (uncomment either__iter__implementation).