OWA-13 added testing setup and basic test example for React OWA and Redux #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,20 @@ | |||
| require('babel-register')(); | |||
There was a problem hiding this comment.
Could you please put in some docs here? What does it do? And start from the openmrs license...
There was a problem hiding this comment.
This file is just setup for jsdom to create realistic browser environment for testing.
| "enzyme": "^2.7.0", | ||
| "jsdom": "^9.9.1", | ||
| "react-addons-test-utils": "^15.4.2", | ||
| "mocha": "^3.2.0" |
There was a problem hiding this comment.
Any reasons you didn't use Jest as the react team? It's mentioned at https://facebook.github.io/react/docs/test-utils.html ?
There was a problem hiding this comment.
Mocha combined with Enzyme seems to be more popular in the react community. You can check out nice comparison here http://instea.sk/2016/08/testing-react-applications-with-karma-jest-or-mocha/
In overall after spending my first day with React it just seemed to be better option
AdamGrzybkowski
force-pushed
the
OWA-13
branch
4 times, most recently
from
a23649d to
ed96758
Compare
AdamGrzybkowski
force-pushed
the
OWA-13
branch
from
ed96758 to
8ca0008
Compare
AdamGrzybkowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.