Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract:
tpm-fido
can run multi-user, but any virtual device created by either instance would go toseat0
with no way to reassign it.loginctl assign
requiresID_FOR_SEAT
property to be set on the device, which is missing forhidraw
devices due toID_PATH_TAG
not being set for those:In order to add
ID_PATH_TAG
, we needed some way to distinguish between users' uhid devices. I came up with the following construction numbered lower than the aforementioned rule:Clearly, I am using the
country
parent attribute here, but where does it come from? See psanford/uhid#2 to find out ;)