Add 'beacon' prefix to 'data_column_sidecar_computation' metric #14790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatyaRyazantseva
requested review from
potuz,
rkapka and
nisdas
and removed request for
a team
nalepae
force-pushed
the
peerDAS
branch
3 times, most recently
from
d7d370e to
f6b1fb1
Compare
nalepae
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR renames PeerDAS metric
data_column_sidecar_computation_millisecondsintobeacon_data_column_sidecar_computation_millisecondsalign with the PeerDAS metrics specsWhich issues(s) does this PR fix?
Fixes (partially) #14129
Other notes for review
Acknowledgements