Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QRank/Daylight water labels #29

Open
bdon opened this issue Mar 21, 2023 · 6 comments
Open

Add QRank/Daylight water labels #29

bdon opened this issue Mar 21, 2023 · 6 comments

Comments

@bdon
Copy link
Member

bdon commented Mar 21, 2023

https://daylightmap.org/2023/03/20/water-labels.html
https://github.com/brawer/wikidata-qrank
@wipfli
Copy link
Collaborator

wipfli commented Mar 21, 2023

https://github.com/wipfli/swiss-map/blob/cd5b79ace9d786453473b0cfe8b89d76434fc143/planetiler/src/main/java/com/onthegomap/planetiler/examples/QRank.java#L126

@wipfli
Copy link
Collaborator

wipfli commented Mar 21, 2023

@brawer not only made QRank, he also made a big mapping from wikipedia article name to wikidata id: https://qrank-storage.wmcloud.org/qsitelinks/qsitelinks.mdb.zst

This can be helpful for things which have a wikipedia tag but no wikidata tag.

bdon added a commit that referenced this issue Aug 28, 2023
@bdon
qrank db wip [#29]
ecb9eb7
bdon added a commit that referenced this issue Aug 30, 2023
@bdon
WIP on initializing NE database [#108] (#110)
afd222d 
Replace RegionInfos, CountryInfos and NE index with NaturalEarthDb on init [#108]

* NaturalEarthDb cleans up NE duplicates and is queried in-memory by Places layer
* move ne zoom adjustment and null-handling into layers
* Add QrankDb, but don't use it to rank POIs yet [#29]
@bdon
Copy link
Member Author

bdon commented Sep 6, 2023

requirement via @nvkelso to be solved

Can the Seattle space needle show up earlier? It's otherwise just an attraction shown at later zooms. Consider a variant of the area boost a height boost?

@nvkelso
Copy link
Collaborator

nvkelso commented Sep 6, 2023

BTW, adding height boost mostly solved the Seattle Space Needle example. But it's a good test case non-the-less!

@bdon
Copy link
Member Author

bdon commented Oct 11, 2024

  • Black sea -- missing all together!?
  • Caspian sea -- only at high zoom
  • Water names should be joined and consistent low and high zooms. See North American great lakes (Lake Huron versus Huron)

@wipfli
Copy link
Collaborator

wipfli commented Mar 11, 2025

We can add some special rules for selected water bodies at low zooms with #416 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bdon @nvkelso @wipfli