water matcher #1005
wipflisonar.yml
on: pull_request
Analyze with Sonar
1m 28s
Annotations
10 warnings
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Earth.java#L39
Define a constant instead of duplicating this literal "ne_50m_land" 3 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZWElD-1AwbI-i2C6ey5&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landcover.java#L38
Replace this use of System.out by a logger.
rule: java:S106 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS106&rule_key=java%3AS106)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZWElD8cAwbI-i2C6ey4&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L36
Define a constant instead of duplicating this literal "featurecla" 5 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cT&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L37
Define a constant instead of duplicating this literal "min_zoom" 9 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cN&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L37
Define a constant instead of duplicating this literal "minZoom" 16 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cV&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L38
Define a constant instead of duplicating this literal "ocean" 4 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cX&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L74
Define a constant instead of duplicating this literal "natural" 6 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cQ&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L85
Define a constant instead of duplicating this literal "kindDetail" 4 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cL&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L88
Define a constant instead of duplicating this literal "waterway" 8 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cU&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Water.java#L108
Define a constant instead of duplicating this literal "canal" 4 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=416&open=AZV7cG2BSch4_0A2e0cO&id=protomaps_basemaps
|