Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: multiple web.listen-address args results into an error, if --config.file is defined. #1876

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Feb 9, 2025

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes and the area they affect
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

…config.file is defined.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…config.file is defined.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…config.file is defined.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
…config.file is defined.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link

@zajdee zajdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has fixed #1871.

@jkroepke jkroepke merged commit 96ffc3b into prometheus-community:master Feb 12, 2025
9 checks passed
@jkroepke jkroepke deleted the config-file-ports branch February 12, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants