generated from mgramigna/typescript-node-starter
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial must supports added to data requirement #294
Draft
lmd59
wants to merge
14
commits into
master
Choose a base branch
from
must-supports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,275
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportCaution Test run failed
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run failedFailed tests: 0/438. Failed suites: 1/31.
Report generated by 🧪jest coverage report action from 5473102 |
add main code path make sure stack match is stopped by expression types that pull stack out of the current retrieve context
, compare alias references, and traverse across functions keeping track of the correct name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an in progress PR to improve our data requirements and add mustSupport properties.
Current state
Currently all mustSupports match elm-parser-for-ecqms mustSupports for CMS2 (as long as multiple data requirements with the same vs/code are lined up properly) and CMS130 for first level properties (i.e. comparing "diagnosis", but not "diagnosis.condition"). The logic finds all properties, then goes through each retrieve to see if the property is applicable to that retrieve. The logic does a lot of ELM traversal and so is slow at this point and would benefit from further optimization
Next steps
We're currently paused on this effort because we may need a new approach to capture all must Supports generically. Looking at elm-parser-for-ecqms may be helpful, but because it uses the xPath, there may be some approaches taken there that are unavailable to us. Our current plan is to next create a function that takes an expression and figures out what retrieves are resultant from that expression. This will be difficult to create but would let us simplify the complexity of matching properties with retrieves and allow for a more general solution.
May not be useful, but another potential help is that we may be able to keep track of more as we create the initial retrieves structure and track what a retrieve is called on the way (i.e. alias, expression references, operands) and the associated context of that name?
New behavior
Code changes
Testing guidance