Make attribute required for ValueFilter

projecttacoma · Jan 31, 2025 · 7ef6c67 · 7ef6c67
1 parent 9e7aea5
commit 7ef6c67
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/helpers/elm/QueryFilterParser.ts b/src/helpers/elm/QueryFilterParser.ts
@@ -1184,7 +1184,8 @@ export function interpretComparator(
 
   const valueFilter: ValueFilter = {
     type: 'value',
-    comparator: comparatorString
+    comparator: comparatorString,
+    attribute: propRef.path
   };
   const op = comparatorELM.operand[1];
 
@@ -1218,9 +1219,6 @@ export function interpretComparator(
   if (propRef.scope) {
     valueFilter.alias = propRef.scope;
   }
-  if (propRef.path) {
-    valueFilter.attribute = propRef.path;
-  }
   return valueFilter;
 }
 

diff --git a/src/types/QueryFilterTypes.ts b/src/types/QueryFilterTypes.ts
@@ -158,7 +158,7 @@ export interface codeFilterQuery {
 
 export interface ValueFilter extends Filter {
   type: 'value';
-  attribute?: string;
+  attribute: string;
   alias?: string;
   comparator: ValueFilterComparator;
   valueBoolean?: boolean;
@@ -169,5 +169,5 @@ export interface ValueFilter extends Filter {
   valueRange?: fhir4.Range;
 }
 
-// Information on these comparators found here: http://build.fhir.org/ig/HL7/cqf-measures/ValueSet-value-filter-comparator.html
+// Information on these comparators found here: https://build.fhir.org/ig/HL7/fhir-extensions/StructureDefinition-cqf-valueFilter.html
 export type ValueFilterComparator = 'eq' | 'gt' | 'lt' | 'ge' | 'le' | 'sa' | 'eb';