From 366cc6c55db8468227fa4f965619de469e2fdf73 Mon Sep 17 00:00:00 2001 From: newclarityex <69740123+newclarityex@users.noreply.github.com> Date: Thu, 6 Feb 2025 11:03:47 -0500 Subject: [PATCH 1/3] adjust packet size constant --- src/server/replication_messages/mutate_message.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server/replication_messages/mutate_message.rs b/src/server/replication_messages/mutate_message.rs index 0b6e2699..e9fa661f 100644 --- a/src/server/replication_messages/mutate_message.rs +++ b/src/server/replication_messages/mutate_message.rs @@ -224,7 +224,8 @@ impl MutateMessage { } fn can_pack(message_size: usize, add: usize) -> bool { - const MAX_PACKET_SIZE: usize = 1200; // TODO: make it configurable by the messaging backend. + // Max size allowed by quinn datagrams + const MAX_PACKET_SIZE: usize = 1162; // TODO: make it configurable by the messaging backend. let dangling = message_size % MAX_PACKET_SIZE; (dangling > 0) && ((dangling + add) <= MAX_PACKET_SIZE) From 4db69e81041afabf2f2d49410b83fdafdbf0c92f Mon Sep 17 00:00:00 2001 From: Hennadii Chernyshchyk Date: Thu, 6 Feb 2025 20:02:25 +0200 Subject: [PATCH 2/3] Update src/server/replication_messages/mutate_message.rs --- src/server/replication_messages/mutate_message.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/server/replication_messages/mutate_message.rs b/src/server/replication_messages/mutate_message.rs index e9fa661f..f7c082f4 100644 --- a/src/server/replication_messages/mutate_message.rs +++ b/src/server/replication_messages/mutate_message.rs @@ -224,8 +224,9 @@ impl MutateMessage { } fn can_pack(message_size: usize, add: usize) -> bool { - // Max size allowed by quinn datagrams - const MAX_PACKET_SIZE: usize = 1162; // TODO: make it configurable by the messaging backend. + // Max size allowed by quinn datagrams. + // TODO: make it configurable by the messaging backend. + const MAX_PACKET_SIZE: usize = 1162; let dangling = message_size % MAX_PACKET_SIZE; (dangling > 0) && ((dangling + add) <= MAX_PACKET_SIZE) From 673caad16b6bfc654681ac40fc2d5f3b48a23d86 Mon Sep 17 00:00:00 2001 From: Hennadii Chernyshchyk Date: Thu, 6 Feb 2025 20:25:56 +0200 Subject: [PATCH 3/3] Update test --- src/server/replication_messages/mutate_message.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/server/replication_messages/mutate_message.rs b/src/server/replication_messages/mutate_message.rs index f7c082f4..d86eba3b 100644 --- a/src/server/replication_messages/mutate_message.rs +++ b/src/server/replication_messages/mutate_message.rs @@ -239,13 +239,13 @@ mod tests { #[test] fn packing() { assert!(can_pack(10, 5)); - assert!(can_pack(10, 1190)); - assert!(!can_pack(10, 1191)); + assert!(can_pack(10, 1152)); + assert!(!can_pack(10, 1153)); assert!(!can_pack(10, 3000)); - assert!(can_pack(1199, 1)); - assert!(!can_pack(1200, 0)); - assert!(!can_pack(1200, 1)); - assert!(!can_pack(1200, 3000)); + assert!(can_pack(1161, 1)); + assert!(!can_pack(1162, 0)); + assert!(!can_pack(1162, 1)); + assert!(!can_pack(1162, 3000)); } }