Adjust packet size constant #407
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 51 51
Lines 2773 2773
=======================================
Hits 2489 2489
Misses 284 284 ☔ View full report in Codecov by Sentry. |
| // Max size allowed by quinn datagrams. | ||
| // TODO: make it configurable by the messaging backend. | ||
| const MAX_PACKET_SIZE: usize = 1162; |
There was a problem hiding this comment.
I'd rather not inflict quinn implementation details on the other backends. Maybe it's time to implement the make it configurable by the messaging backend.
There was a problem hiding this comment.
I agree, I just wanted to make a temporary solution to fix the issue with quinn in a patch release.
Ideally I want resources as components to provide a nicer interaction with backends.
There was a problem hiding this comment.
It should be easy enough to implement: add the setting to RepliconServer, let backends override it/edit it. If a quinn user desperately needs a workaround then they can pin to this branch until a proper solution is implemented.
We can't publish regressions on purpose in patch releases.
There was a problem hiding this comment.
Looks like in QUIC it's a variable value per-connection. So it needs to be on ReplicatedClients.
I though using a more conservative value is not that bad, but you are right. I will convert this branch into a draft and implement a proper solution later.
Adjusts packet size constant to match quinn