Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make systems standalone functions #403

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Make systems standalone functions #403

merged 2 commits into from
Feb 3, 2025

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Feb 2, 2025

I used to put systems under plugin impls to clarify that the system belongs to a plugin.
But looks like in Bevy using standalone systems is more common. I think it's especially makes sense now with observers. Let's follow this pattern.

I used to put systems under plugin impls to clarify that the system belongs to a plugin.
But looks like in Bevy using standalone systems is more common. I think it's especially makes sense now with observers. Let's follow this pattern.
@Shatur Shatur enabled auto-merge (squash) February 2, 2025 10:41
@Shatur Shatur requested a review from UkoeHB February 2, 2025 10:41
Shatur added a commit that referenced this pull request Feb 2, 2025
Like #403, but for the example transport and its examples.
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 97.65101% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.78%. Comparing base (c2372b7) to head (eccd340).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/server.rs 93.68% 6 Missing ⚠️
src/parent_sync.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   89.81%   89.78%   -0.03%     
==========================================
  Files          51       51              
  Lines        2778     2771       -7     
==========================================
- Hits         2495     2488       -7     
  Misses        283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur merged commit 0ddeeba into master Feb 3, 2025
7 checks passed
@Shatur Shatur deleted the standalone-systems branch February 3, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants