Abstract I/O #204
Merged
Abstract I/O #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current implementation in order to disconnect user need to write library-specific code. For example, in case of renet user will need to call `RenetClient::disconnect` or remove `RenetClient` resource. I think we can do better by hiding `RepliconServer::set_active` and `RepliconClient::set_status` and providing events for messaging libraries and users to control it. But I will probably do it in a follow-up PR. We can include more library-independent things into `RepliconServer`, but I would also do it in a follow-up PRs.
Shatur
force-pushed
the
io-abstraction
branch
from
e4b00cd to
a50fa8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 89.37% 90.72% +1.35%
==========================================
Files 21 28 +7
Lines 1421 1672 +251
==========================================
+ Hits 1270 1517 +247
- Misses 151 155 +4 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Feb 27, 2024
Closed
I think these resorces need to be removed, otherwise renet will spam a lot of errors. Going to figure it out + check the server logic properly.
I think we need to provide some sort of communication to handle replicon struct states properly. Let's keep it for the future.
Co-authored-by: UkoeHB <37489173+UkoeHB@users.noreply.github.com>
For consistency.
Do not export conditions, plugins and schedules.
UkoeHB
requested changes
Mar 4, 2024
src/server/replication_messages.rs
Outdated
| @@ -662,7 +663,7 @@ fn write_with<'a>( | |||
| } | |||
|
|
|||
| fn can_pack(header_size: usize, base: usize, add: usize) -> bool { | |||
| const MAX_PACKET_SIZE: usize = 1200; // https://github.com/lucaspoffo/renet/blob/acee8b470e34c70d35700d96c00fb233d9cf6919/renet/src/packet.rs#L7 | |||
| const MAX_PACKET_SIZE: usize = 1200; | |||
There was a problem hiding this comment.
Maybe this should be configurable by the backend, can be done in a future PR.
Co-authored-by: UkoeHB <37489173+UkoeHB@users.noreply.github.com>
UkoeHB
requested changes
Mar 4, 2024
Co-authored-by: UkoeHB <37489173+UkoeHB@users.noreply.github.com>
Co-authored-by: UkoeHB <37489173+UkoeHB@users.noreply.github.com>
Shatur
commented
Mar 4, 2024
| client.filter(|client| client.is_connected()).is_some() | ||
| } | ||
|
|
||
| /// Returns `true` if the server stopped on this tick. |
There was a problem hiding this comment.
@UkoeHB maybe clarity that it's not exactly on this tick, but more like since the condition run? Because if you run this condition again on the same "stopped" tick, it will return false.
There was a problem hiding this comment.
- Bevy runs all run conditions every tick.
- Separate instances of this run condition will have different locals, so individual instances won't be run twice on the same tick.
There was a problem hiding this comment.
Ah, it's Bevy's tick. I assumed that we meant replicon tick as in other places.
UkoeHB
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation in order to disconnect user need to write library-specific code. For example, in case of renet user will need to call
RenetClient::disconnector removeRenetClientresource.I think we can do better by hidingI decided to keep only minimal functionality inRepliconServer::set_runningandRepliconClient::set_statusand providing events for messaging libraries and users to control it. But I will probably do it in a follow-up PR.RepliconServerandRepliconClientrequired for replicon to function.