Update to Bevy 0.13 #198
Update to Bevy 0.13 #198
Conversation
Migrate to bevy 0.13 - PR on rennet (lucaspoffo/renet#147) - Deprecated `MapNetworkEntities` and `Mapper` - Conditions systems follow the new Bevy pattern - Needs review for entity serialization id
There was a problem hiding this comment.
Thank you a lot!
Could you please apply formatting, fix doctests and silence deprecation warnings for existing Mapper impls to make CI happy?
Also I would appreciate if you update the changelog :)
But it's all optional, I can do all of the above myself later.
|
There is a test on the other.rs that as 5 more bytes on the stats. I silence the assert, since I don't see any regressions, and maybe something from the rennet update.
I agree, I just deprecated mostly because of the comment on #185. |
Yes remove it. By 'deprecate' I just meant to use Bevy's instead (not a rust deprecation). |
|
@dgsantana could you remove it then? |
|
Of course. Also bevy_renet should be ready to be merged. Bevy_egui is now published. |
Great! But |
…and `MapEntities`
|
@UkoeHB could you take a look into entity serialization? |
|
Ok let's do it in a new PR (easier for me to handle). |
|
There is something broken on component serialization, the client receives always 0 bytes after the entity id. I'm debugging on a different branch. |
|
Make sure to apply changes from |
I did, but there is something broken probably on the collect_changes on the server... I have to leave for a few hours, but will look into this later on. |
Unfortunately, we can't link to external crates. But we can mention that it's from Bevy (since it's not a well-known trait).
|
Pushed some minor changes to make CI happy.
Are you sure? Because all tests pass and all examples work. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 89.06% 89.12% +0.05%
==========================================
Files 20 20
Lines 1427 1416 -11
==========================================
- Hits 1271 1262 -9
+ Misses 156 154 -2 ☔ View full report in Codecov by Sentry. |
|
Great! |
I'm pulling all changes from the current PR into my instrumented branch just to double check everything. |
|
It's very weird... Left is Server, Right is Client. The entities are send, but not the components, the buffer after reading the entity is just empty on the client side. But Tic Tac Toe is working. |
|
Could you provide a minimal example to reproduce? |
I will try to create a minimal sample or test for this. |
|
Ok here goes a "minimal" example. It uses a menu system to handle the connection, instead of the command line. And it as the issue. Feel free to use as a extra example. |
|
@dgsantana it looks like you are not registering any components for replication. Docs |
Ok, I made it too minimal. I removed serde by mistake. |
|
Oook, manually registering with |
|
Ok it was my bad, I indeed forgot to register the components for replication, sorry for the false alarm. |
Since we are working on a simple game that is using replicon, and we would like to switch to 0.13, to catch any early bugs and take advantage of the new features, I made this PR.
Changes:
MapNetworkEntities->MapEntitesandMapper->EntityMapperMissing review of entity id serialization, couldn't find where it was.