-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't panic on race condition in client info updating #173
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 89.90% 89.94% +0.03%
==========================================
Files 19 19
Lines 1209 1213 +4
==========================================
+ Hits 1087 1091 +4
Misses 122 122 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice!
I will make it pub in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve conflicts with master?
This line would panic erroneously due to a race condition between despawns and client acks:
.expect("tick should be inserted on any component insertion");
.I moved the implementation details of
ClientInfo
inside its impl. One reason this bug occurred is the implementation logic was not self-contained so it was hard to reason about.