Hide extra functionality from ServerEventQueue
#164
Merged
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shatur
force-pushed
the
server-event-queue
branch
from
f5d08f3 to
e3a6fe5
Compare
Shatur
force-pushed
the
server-event-queue
branch
from
e3a6fe5 to
6c99614
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 83.37% 90.68% +7.31%
==========================================
Files 20 19 -1
Lines 1287 1181 -106
==========================================
- Hits 1073 1071 -2
+ Misses 214 110 -104 ☔ View full report in Codecov by Sentry. |
UkoeHB
reviewed
Jan 10, 2024
src/network_event/server_event.rs
Outdated
| /// Inserts a new event. | ||
| /// | ||
| /// The event will be queued until [`Self::pop_next`] is called with a replicon tick >= the tick specified here, | ||
| /// or until [`Self::clear`] is called. | ||
| /// The event will be queued until [`RepliconTick`] will be bigger or equal to the tick specified here. |
There was a problem hiding this comment.
Suggested change
| /// The event will be queued until [`RepliconTick`] will be bigger or equal to the tick specified here. | |
| /// The event will be queued until [`RepliconTick`] is bigger or equal to the tick specified here. |
UkoeHB
reviewed
Jan 10, 2024
src/network_event/server_event.rs
Outdated
Comment on lines
362
to
369
| /// Pops the next event that is at least as old as the specified replicon tick. | ||
| pub fn pop_next(&mut self, replicon_tick: RepliconTick) -> Option<T> { | ||
| let (tick, _) = self.0.front()?; | ||
| if *tick > replicon_tick { | ||
| return None; | ||
| } | ||
| self.0.pop_front().map(|(_, event)| event) | ||
| } |
There was a problem hiding this comment.
I would prefer to keep this and just change the visibility, to isolate implementation details from other parts of the code.
There was a problem hiding this comment.
Agree, but I adjusted the name a little bit.
UkoeHB
reviewed
Jan 10, 2024
Co-authored-by: UkoeHB <37489173+UkoeHB@users.noreply.github.com>
UkoeHB
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discord we discussed customization without the full access to
ServerEventQueue.