test/e2e: replace fixed sleeps with require.Eventually #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the endpoint slice E2E test faster and less likely to flake. Closes projectcontour#5974. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added
the
release-note/none-required
skriss
requested review from
tsaarni and
stevesloka
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5975 +/- ##
=======================================
Coverage 78.62% 78.62%
=======================================
Files 138 138
Lines 19631 19631
=======================================
Hits 15434 15434
Misses 3894 3894
Partials 303 303 |
sunjayBhatia
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the endpoint slice E2E test faster and
less likely to flake.
Closes #5974.