release note

Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
projectcontour · Dec 12, 2023 · 589633f · 589633f
1 parent 46629af
commit 589633f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/changelogs/unreleased/6013-davinci26-small.md b/changelogs/unreleased/6013-davinci26-small.md
@@ -0,0 +1,4 @@
+## Support for Global Circuit Breaker Policy
+
+The way (circuit-breaker-annotations)[https://projectcontour.io/docs/1.27/config/annotations/] work currently is that when not present they are being defaulted to Envoy defaults. The Envoy defaults can be quite low for larger clusters with more traffic so if
+a user accidentally deletes them or unset them this cause an issue. With this change we are providing contour administrators the ability to provide global defaults that are good. In that case even if the user forgets to set them or deletes them they can have the safety net of good defaults.
diff --git a/internal/dag/dag.go b/internal/dag/dag.go
@@ -1042,15 +1042,6 @@ type Cluster struct {
 	PerConnectionBufferLimitBytes *uint32
 }
 
-// CircuitBreakerPolicy defines the circuit breaker policy for a cluster.
-type CircuitBreakerPolicy struct {
-	// IdleConnectionTimeout is the timeout applied to idle connection.
-	IdleConnectionTimeout timeout.Setting
-
-	// ConnectTimeout defines how long the proxy should wait when establishing connection to upstream service.
-	ConnectTimeout time.Duration
-}
-
 // WeightedService represents the load balancing weight of a
 // particular v1.Weighted port.
 type WeightedService struct {