-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync namespace metadata on creation. #1378
Comments
Signed-off-by: Siarhei Rasiukevich <s_rasiukevich@wargaming.net>
Signed-off-by: Siarhei Rasiukevich <s_rasiukevich@wargaming.net>
I understand you'd like to deploy Pods as quickly as possible. Still, there's another problem: the Happy to hear more about your use case, tho: I've strong opinions, weakly held. @oliverbaehler what are your thoughts on this? |
The benefits is that pods can started before namespace has node-selector annotation. |
I am working on something like a |
Signed-off-by: Siarhei Rasiukevich <s_rasiukevich@wargaming.net>
Signed-off-by: Siarhei Rasiukevich <s_rasiukevich@wargaming.net>
Signed-off-by: Siarhei Rasiukevich <s_rasiukevich@wargaming.net>
We need to sync namespace metadata (labels, annotation and especially nodeSelector) on namespace creation.
For now, namespace nodeSelector reconciled by controller loop and pod can start before nodeSelector will be set on ns (in case of huge amount of namespaces).
Let's add some extra logic to namespace webhook.
*Have prepared PR for this already.
The text was updated successfully, but these errors were encountered: