fix(form): showing of field value in case of calculated questions #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maria-pw
force-pushed
the
fix-form-show-value-for-calculations
branch
from
ac707ad to
fe4d49f
Compare
anehx
requested changes
Nov 28, 2024
maria-pw
force-pushed
the
fix-form-show-value-for-calculations
branch
from
fe4d49f to
e69dc04
Compare
anehx
approved these changes
Nov 28, 2024
luytena
approved these changes
Nov 28, 2024
|
🎉 This PR is included in version 13.1.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is supposed to fix the value of a calculated_float field not showing in a table row.
The value does not show up currently because the answer for calculated_float fields is not written, just evaluated (see
get calculatedValue()inpackages/form/addon/lib/field.js)Depedencies
no dependencies