feat: enable JEXLs for options in choice and multiple choice questions #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanH90
force-pushed
the
feat/options-jexls
branch
from
adc8c8c to
879e2c7
Compare
StephanH90
added
enhancement
StephanH90
force-pushed
the
feat/options-jexls
branch
3 times, most recently
from
f8a40b5 to
6ce5c3e
Compare
StephanH90
force-pushed
the
feat/options-jexls
branch
from
6ce5c3e to
892b885
Compare
luytena
force-pushed
the
feat/options-jexls
branch
from
892b885 to
d5ef8e3
Compare
luytena
reviewed
Jan 31, 2025
packages/form-builder/addon/components/cfb-form-editor/question-option.hbs
Outdated
Show resolved
Hide resolved
packages/form-builder/addon/components/cfb-form-editor/question-option.hbs
Outdated
Show resolved
Hide resolved
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds JEXLs to options for choice and multiple choice questions.
If an option has been selected which becomes invisible due to it's JEXL it behaves like an option that isn't available anymore.
Form builder:
Fixes # (issue)
Depedencies
Depends on
projectcaluma/caluma#2269(merged)