fix: incorporate review feedback

packages/form/addon/components/cf-field/input/radio.hbs

@@ -23,10 +23,9 @@
     {{/if}}
   </label>
 {{/each}}
-{{#if (and (eq @field.question.raw.isRequired "false") @field.answer.value)}}
+{{#if (and @field.optional @field.answer.value)}}
   <br />
-  <a data-test-radio-reset href="#" {{on "click" (fn @onSave null)}}>{{t
+  <a href="" data-test-radio-reset {{on "click" this.reset}}>{{t
       "caluma.form.power-select.reset"
     }}</a>
-
 {{/if}}

packages/form/addon/components/cf-field/input/radio.js

@@ -0,0 +1,11 @@
+import { action } from "@ember/object";
+import Component from "@glimmer/component";
+
+export default class CfFieldInpuRadio extends Component {
+  @action
+  reset(event) {
+    event.preventDefault();
+
+    this.args.onSave(null);
+  }
+}

packages/form/package.json

@@ -35,7 +35,6 @@
     "ember-math-helpers": "^4.0.0",
     "ember-power-select": "^7.2.0",
     "ember-resources": "^6.4.2",
-    "ember-truth-helpers": "^4.0.3",
     "ember-uikit": "^9.0.0",
     "ember-validators": "^4.1.2",
     "graphql": "^15.8.0",

packages/form/tests/integration/components/cf-field/input/radio-test.js

@@ -87,27 +87,28 @@ module("Integration | Component | cf-field/input/radio", function (hooks) {
 
   test("it triggers save on click", async function (assert) {
     this.set("value", false);
-    this.set("raw", { isRequired: "false" });
+    this.set("optional", true);
     this.set("onSave", (value) => {
       this.set("value", value);
       assert.step("save");
     });
 
     await render(hbs`<CfField::Input::Radio
-  @onSave={{this.onSave}}
-  @field={{hash
-    options=(array (hash slug="option-1" label="Option 1"))
-    answer=(hash value=this.value)
-    question=(hash __typename="ChoiceQuestion" slug="test" raw=this.raw)
-  }}
-/>`);
+      @onSave={{this.onSave}}
+      @field={{hash
+        options=(array (hash slug="option-1" label="Option 1"))
+        answer=(hash value=this.value)
+        question=(hash __typename="ChoiceQuestion" slug="test" )
+        optional=this.optional
+      }}
+    />`);
 
     await click("label:nth-of-type(1) input");
     await click("[data-test-radio-reset]");
 
     assert.verifySteps(["save", "save"]);
 
-    this.set("raw", { isRequired: "true" });
+    this.set("optional", false);
     await click("label:nth-of-type(1) input");
 
     assert.verifySteps(["save"]);