Ensure that the search bar is visible when focused via anchor link #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The anchor links in the skip links navigation cause the search bar to be focused when activated, but in some cases the bar itself is scrolled up and out of view, making it hard to interact with after focusing. This adds some styling to create an extra scroll margin so that the search elements stay within view when focused using an anchor link. Ref sul-dlss/earthworks#1467
jcoyne
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anchor links in the skip links navigation cause the search
bar to be focused when activated, but in some cases the bar itself
is scrolled up and out of view, making it hard to interact with
after focusing.
This adds some styling to create an extra scroll margin so that
the search elements stay within view when focused using an anchor
link.
Ref sul-dlss/earthworks#1467
Before
anchor_bad.mov
After
anchor_good.mov