From 2fa70cf963a5feb6b81b765f7bdf32e96ec45178 Mon Sep 17 00:00:00 2001
From: Nick Budak <budak@stanford.edu>
Date: Wed, 30 Oct 2024 13:34:52 -0700
Subject: [PATCH] Use a labeled <aside> for show tools sidebar

The show page sidebar is currently displayed
inside a <section>; this changes it to use the <aside> element,
which is arguably more appropriate for a sidebar.

The search sidebar has an aria-label already set, but the show
sidebar did not, which also meant that it had no accessible name
despite having a landmark role.

Thus this also adds a configurable aria-label for the show page sidebar
similar to the one for the search sidebar.
---
 app/views/layouts/catalog_result.html.erb | 4 ++--
 config/locales/blacklight.ar.yml          | 4 ++++
 config/locales/blacklight.de.yml          | 4 ++++
 config/locales/blacklight.en.yml          | 4 ++++
 config/locales/blacklight.es.yml          | 4 ++++
 config/locales/blacklight.fr.yml          | 4 ++++
 config/locales/blacklight.hu.yml          | 4 ++++
 config/locales/blacklight.it.yml          | 4 ++++
 config/locales/blacklight.nl.yml          | 4 ++++
 config/locales/blacklight.pt-BR.yml       | 4 ++++
 config/locales/blacklight.sq.yml          | 4 ++++
 config/locales/blacklight.zh.yml          | 4 ++++
 12 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/app/views/layouts/catalog_result.html.erb b/app/views/layouts/catalog_result.html.erb
index 39df953ef8..60a212e161 100644
--- a/app/views/layouts/catalog_result.html.erb
+++ b/app/views/layouts/catalog_result.html.erb
@@ -3,9 +3,9 @@
     <%= yield %>
   </section>
 
-  <section class="<%= show_sidebar_classes %>">
+  <aside class="<%= show_sidebar_classes %>" aria-label="<%= t('.aria.sidebar') %>">
     <%= content_for(:sidebar) %>
-  </section>
+  </aside>
 <% end %>
 
 <%= render template: "layouts/blacklight/base" %>
diff --git a/config/locales/blacklight.ar.yml b/config/locales/blacklight.ar.yml
index e5ebc60769..df4b67d80b 100644
--- a/config/locales/blacklight.ar.yml
+++ b/config/locales/blacklight.ar.yml
@@ -219,6 +219,10 @@ ar:
       aria:
         container_label: التنقل الرئيسي
     welcome: مرحبًا!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: أدوات
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.de.yml b/config/locales/blacklight.de.yml
index 3838f11010..70308f08fa 100644
--- a/config/locales/blacklight.de.yml
+++ b/config/locales/blacklight.de.yml
@@ -206,6 +206,10 @@ de:
       aria:
         container_label: Hauptnavigation
     welcome: Willkommen!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Werkzeuge
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.en.yml b/config/locales/blacklight.en.yml
index ab427c6e05..13dd4bd3e6 100644
--- a/config/locales/blacklight.en.yml
+++ b/config/locales/blacklight.en.yml
@@ -242,3 +242,7 @@ en:
     pagination_compact:
       next: Next &raquo;
       previous: "&laquo; Previous"
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Tools
diff --git a/config/locales/blacklight.es.yml b/config/locales/blacklight.es.yml
index 604d8cce97..4b281149dd 100644
--- a/config/locales/blacklight.es.yml
+++ b/config/locales/blacklight.es.yml
@@ -205,6 +205,10 @@ es:
       aria:
         container_label: Navegación principal
     welcome: "¡Bienvenido!"
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Herramientas
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.fr.yml b/config/locales/blacklight.fr.yml
index 30c60603b5..a372ff5831 100755
--- a/config/locales/blacklight.fr.yml
+++ b/config/locales/blacklight.fr.yml
@@ -205,6 +205,10 @@ fr:
       aria:
         container_label: Navigation principale
     welcome: Welcome!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Outils
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.hu.yml b/config/locales/blacklight.hu.yml
index dadba8cfdb..65b3493a74 100644
--- a/config/locales/blacklight.hu.yml
+++ b/config/locales/blacklight.hu.yml
@@ -203,6 +203,10 @@ hu:
       aria:
         container_label: Fő navigáció
     welcome: Üdvözöljük!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Eszközök
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.it.yml b/config/locales/blacklight.it.yml
index e71637b08f..202ccdc354 100644
--- a/config/locales/blacklight.it.yml
+++ b/config/locales/blacklight.it.yml
@@ -206,6 +206,10 @@ it:
       aria:
         container_label: Navigazione principale
     welcome: Benvenuti!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Utensili
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.nl.yml b/config/locales/blacklight.nl.yml
index 8e8d829b76..47e66700ab 100644
--- a/config/locales/blacklight.nl.yml
+++ b/config/locales/blacklight.nl.yml
@@ -203,6 +203,10 @@ nl:
       aria:
         container_label: Hoofdnavigatie
     welcome: Welkom!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Hulpmiddelen
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.pt-BR.yml b/config/locales/blacklight.pt-BR.yml
index aea5b6a6c4..479ce39478 100644
--- a/config/locales/blacklight.pt-BR.yml
+++ b/config/locales/blacklight.pt-BR.yml
@@ -204,6 +204,10 @@ pt-BR:
       aria:
         container_label: Navegação principal
     welcome: Bem-Vindo!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Ferramentas
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.sq.yml b/config/locales/blacklight.sq.yml
index 9ced9ef28d..59c09dfc41 100644
--- a/config/locales/blacklight.sq.yml
+++ b/config/locales/blacklight.sq.yml
@@ -203,6 +203,10 @@ sq:
       aria:
         container_label: Lundrimi kryesor
     welcome: Mirësevini!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: Mjetet
   views:
     pagination:
       aria:
diff --git a/config/locales/blacklight.zh.yml b/config/locales/blacklight.zh.yml
index 327a4c9369..0da079c3d1 100644
--- a/config/locales/blacklight.zh.yml
+++ b/config/locales/blacklight.zh.yml
@@ -203,6 +203,10 @@ zh:
       aria:
         container_label: 主导航
     welcome: 欢迎!
+  layouts:
+    catalog_result:
+      aria:
+        sidebar: 工具
   views:
     pagination:
       aria: