-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add game pagination to DatabaseReplayProvider #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
approved these changes
Nov 18, 2023
867a2bc
to
3d5356a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds pagination support when fetching games.
How it works
1. When fetching from the database, fetch
limit + 1
items.This allows us to determine if we actually have any more items to return, in order to populate the
continuation
token. If this string is populated, there are more records to come. If there is no continuation token, all records have been fetched.2. Take the last item returned from the records and encode it into a continuation token.
We need to be able to refer to each item in the list of records, in a deterministicly sorted order. We do this by taking the key that it's sorted by e.g. game start time, and the record ID, and when returning results always sort by these two columns. We return the continuation token in the base64 encoded form of
${value},${lastRecordId}
.3. When fetching more items, pass the previous continuation token.
The continuation token is decoded back into the order by key in order to re-fetch the previous query, and using a specially crafted where-clause to start from the expected record (the limit + 1 record from before). The frontend renderer is responsible for storing and re-sending the continuation token as needed.
Resources
Here are some resources which I found useful when implementing pagination.