fix: clear temp folder from main on startup before replay playback is…

… setup

otherwise double clicking a replay when the launcher isn't yet open will delete the comm file before dolphin can read it

src/main/main.ts

@@ -29,7 +29,7 @@ import { fileExists } from "utils/file_exists";
 import { getConfigFlags } from "./flags/flags";
 import { installModules } from "./install_modules";
 import { MenuBuilder } from "./menu";
-import { resolveHtmlPath } from "./util";
+import { clearTempFolder, resolveHtmlPath } from "./util";
 
 const BACKGROUND_COLOR = "#1B0B28";
 
@@ -88,6 +88,17 @@ const createWindow = async () => {
     await installExtensions();
   }
 
+  // clear temp files safely before the app has fully started and replays are being loaded for playback
+  try {
+    await clearTempFolder();
+  } catch (err) {
+    // silently fail since this isn't a critical issue
+    log.error(
+      `Could not clear temp folder on startup due to:
+      ${err instanceof Error ? err.message : JSON.stringify(err)}`,
+    );
+  }
+
   mainWindow = new BrowserWindow({
     show: false,
     width: 1100,

src/main/setup.ts

@@ -6,7 +6,6 @@ import { app, clipboard, dialog, ipcMain, nativeImage, shell } from "electron";
 import electronLog from "electron-log";
 import type { ProgressInfo, UpdateInfo } from "electron-updater";
 import { autoUpdater } from "electron-updater";
-import * as fs from "fs-extra";
 import path from "path";
 import { fileExists } from "utils/file_exists";
 
@@ -30,7 +29,7 @@ import {
 } from "./ipc";
 import { getNetworkDiagnostics } from "./network_diagnostics";
 import { fetchNewsFeedData } from "./news_feed";
-import { getAssetPath, readLastLines } from "./util";
+import { clearTempFolder, getAssetPath, readLastLines } from "./util";
 import { verifyIso } from "./verify_iso";
 
 const log = electronLog.scope("main/listeners");
@@ -163,10 +162,8 @@ export default function setupMainIpc({
   });
 
   ipc_clearTempFolder.main!.handle(async () => {
-    const tmpDir = path.join(app.getPath("userData"), "temp");
     try {
-      await fs.remove(tmpDir);
-      await fs.ensureDir(tmpDir);
+      await clearTempFolder();
     } catch (err) {
       log.error(err);
       throw err;

src/main/util.ts

@@ -78,3 +78,9 @@ export async function readLastLines(
 
   return Buffer.from(allBytes).toString(encoding);
 }
+
+export async function clearTempFolder() {
+  const tmpDir = path.join(app.getPath("userData"), "temp");
+  await fs.remove(tmpDir);
+  await fs.ensureDir(tmpDir);
+}

src/renderer/lib/hooks/use_app.ts

@@ -92,19 +92,6 @@ export const useAppInitialization = () => {
     // Check if there is an update to the launcher
     promises.push(window.electron.common.checkForAppUpdates());
 
-    // Remove any temp files
-    promises.push(
-      (async () => {
-        window.electron.common.clearTempFolder().catch((err) => {
-          // silently fail since this isn't a critical issue
-          log.error(
-            `Could not clear temp folder on startup due to:
-            ${err instanceof Error ? err.message : JSON.stringify(err)}`,
-          );
-        });
-      })(),
-    );
-
     // Wait for all the promises to complete before completing
     try {
       await Promise.all(promises);