Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial closure sample app for 917SoC #37752

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

sabollim-silabs
Copy link
Contributor

@sabollim-silabs sabollim-silabs commented Feb 24, 2025

This PR contains a basic implementation of the closure sample app which includes rootnode as ep0 and closure base as ep1,
will be able to commission over wifi, populate ep1 with closure-control cluster ,give appropriate values for global attributes and return default values for closure control attributes and default success for closure control commands.

Attributes, Commands, and Events handling will be taken up in later PRs

Testing

  1. built app for 917. - Success
  2. commission with chiptool. - Success
  3. check server-list on Ep1 -Success

[1740415369.750] [161165:161167] [TOO] Endpoint: 1 Cluster: 0x0000_001D Attribute 0x0000_0001 DataVersion: 2472008
[1740415369.750] [161165:161167] [TOO] ServerList: 4 entries
[1740415369.750] [161165:161167] [TOO] [1]: 3 (Identify)
[1740415369.750] [161165:161167] [TOO] [2]: 4 (Groups)
[1740415369.750] [161165:161167] [TOO] [3]: 29 (Descriptor)
[1740415369.750] [161165:161167] [TOO] [4]: 260 (ClosureControl)

  1. check attribute list on Ep1 -Success

[1740415387.214] [161266:161274] [TOO] Endpoint: 1 Cluster: 0x0000_0104 Attribute 0x0000_FFFB DataVersion: 2407918899
[1740415387.214] [161266:161274] [TOO] AttributeList: 9 entries
[1740415387.215] [161266:161274] [TOO] [1]: 1 (MainState)
[1740415387.215] [161266:161274] [TOO] [2]: 2 (CurrentErrorList)
[1740415387.215] [161266:161274] [TOO] [3]: 3 (OverallState)
[1740415387.215] [161266:161274] [TOO] [4]: 4 (OverallTarget)
[1740415387.215] [161266:161274] [TOO] [5]: 65532 (FeatureMap)
[1740415387.215] [161266:161274] [TOO] [6]: 65533 (ClusterRevision)
[1740415387.215] [161266:161274] [TOO] [7]: 65528 (GeneratedCommandList)
[1740415387.215] [161266:161274] [TOO] [8]: 65529 (AcceptedCommandList)
[1740415387.215] [161266:161274] [TOO] [9]: 65531 (AttributeList)

@sabollim-silabs sabollim-silabs requested a review from a team as a code owner February 24, 2025 16:44
@sabollim-silabs sabollim-silabs marked this pull request as draft February 24, 2025 16:44
Copy link

semanticdiff-com bot commented Feb 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/app/zap_cluster_list.json  100% smaller
  examples/closure-app/closure-common/BUILD.gn Unsupported file format
  examples/closure-app/closure-common/closure-app.matter Unsupported file format
  examples/closure-app/closure-common/closure-app.zap Unsupported file format
  examples/closure-app/closure-common/closure-control/include/ClosureControlDelegate.h Unsupported file format
  examples/closure-app/closure-common/closure-control/include/ClosureControlInstance.h Unsupported file format
  examples/closure-app/closure-common/closure-control/include/ClosureControlMain.h Unsupported file format
  examples/closure-app/closure-common/closure-control/src/ClosureControlDelegateImpl.cpp Unsupported file format
  examples/closure-app/closure-common/closure-control/src/ClosureControlInstance.cpp Unsupported file format
  examples/closure-app/closure-common/closure-control/src/ClosureControlMain.cpp Unsupported file format
  examples/closure-app/closure-common/common/include/ClosureAppCommonMain.h Unsupported file format
  examples/closure-app/closure-common/common/src/ClosureAppCommonMain.cpp Unsupported file format
  examples/closure-app/silabs/.gn Unsupported file format
  examples/closure-app/silabs/BUILD.gn Unsupported file format
  examples/closure-app/silabs/README.md Unsupported file format
  examples/closure-app/silabs/build_for_wifi_args.gni Unsupported file format
  examples/closure-app/silabs/build_for_wifi_gnfile.gn Unsupported file format
  examples/closure-app/silabs/build_overrides  0% smaller
  examples/closure-app/silabs/include/AppConfig.h Unsupported file format
  examples/closure-app/silabs/include/AppEvent.h Unsupported file format
  examples/closure-app/silabs/include/AppTask.h Unsupported file format
  examples/closure-app/silabs/include/CHIPProjectConfig.h Unsupported file format
  examples/closure-app/silabs/openthread.gn Unsupported file format
  examples/closure-app/silabs/openthread.gni Unsupported file format
  examples/closure-app/silabs/src/AppTask.cpp Unsupported file format
  examples/closure-app/silabs/src/ZclCallbacks.cpp Unsupported file format
  examples/closure-app/silabs/third_party/connectedhomeip  0% smaller
  src/app/chip_data_model.gni Unsupported file format
  src/app/clusters/closure-control-server/closure-control-cluster-objects.h Unsupported file format
  src/app/clusters/closure-control-server/closure-control-server.cpp Unsupported file format
  src/app/clusters/closure-control-server/closure-control-server.h Unsupported file format
  src/app/common/templates/config-data.yaml  0% smaller
  zzz_generated/app-common/app-common/zap-generated/callback.h Unsupported file format

@sabollim-silabs
Copy link
Contributor Author

server code is included in this branch. will be removed once we rebase with master when server code is commited into master

@mergify mergify bot removed the conflict label Feb 24, 2025
Copy link

PR #37752: Size comparison from 7eab378 to 31b8b0a

Full report (1 build for stm32)
platform target config section 7eab378 31b8b0a change % change
stm32 light STM32WB5MM-DK FLASH 459800 459800 0 0.0
RAM 141472 141472 0 0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mention this initially but we should use DataModelCallbacks.cpp now. ZCL was for zigbee and legacy reasons.

Copy link
Contributor Author

@sabollim-silabs sabollim-silabs Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. will adopt to DataModelCallbacks in next phase of app development.
at present we are not handling any attribute or commands.
if needed we can delete this file and take it up totally for next phase.

@sabollim-silabs sabollim-silabs changed the title [WIP] Feature/closure control sample app 917 [WIP] Intial closure sample app for 917SoC Feb 25, 2025
@sabollim-silabs sabollim-silabs changed the title [WIP] Intial closure sample app for 917SoC [WIP] Initial closure sample app for 917SoC Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants