Reset retry counter for subscription resumption once subscription resumption succeeded. #37740
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37740: Size comparison from 43a8a9b to 0c206c3 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…umption succeeded. A retry counter is used to monitor the number of retries done for subscription resumption. Based on this retry counter, a backoff mechanism is in place to calculate the next try for subscription resumption. How bigger the retry counter is, how longer it will take before subscription resumption is retried. It was seen that this retry counter was not reset after the subscription successfully resumed. When after that subscription resumption mechanism is kicked in again, it was using the last retry counter, leading to very big retry timings from the start. This is not desired behavior. This commit makes sure the reset counter is reset after a successful subscription resumption is seen.
dvdm-qorvo
force-pushed
the
subscription_resumption_reset_counter
branch
from
0c206c3 to
703a37f
Compare
|
PR #37740: Size comparison from 43a8a9b to 703a37f Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37738
A retry counter is used to monitor the number of retries done for subscription resumption. Based on this retry counter, a backoff mechanism is in place to calculate the next try for subscription resumption. How bigger the retry counter is, how longer it will take before subscription resumption is retried. It was seen that this retry counter was not reset after the subscription successfully resumed. When after that subscription resumption mechanism is kicked in again, it was using the last retry counter, leading to very big retry timings from the start. This is not desired behavior. This commit makes sure the reset counter is reset after a successful subscription resumption is seen.
Testing
Verified with QPG switch device, tested using instruction listed in #37738