Make robotic vacuum cleaner spec compliant #37718
Open
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is already set to Stopped resulting in dereferencing a null pointer. Fix this by returning from function if state is stopped
|
Review changes with |
|
PR #37718: Size comparison from f84fe08 to fd92b12 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@sxb427 it seems like the tests you ran manually could be automated. Could you do so? |
andy31415
reviewed
Feb 22, 2025
| @@ -122,6 +122,8 @@ void Shutdown(); | |||
| } // namespace app | |||
| } // namespace chip | |||
|
|
|||
| extern std::unique_ptr<chip::app::Clusters::RvcOperationalState::RvcOperationalStateDelegate> gRvcOperationalStateDelegate; | |||
There was a problem hiding this comment.
Would it make more sense to add a getter method instead?
I just realized this is chef not an official application ... I believe it is fine then, we don't run chef CI (too costly to compile) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Testing using chip tool.
Test for 1 and 2
a. Commission.
b. Read operational state and run mode and ensure both are 0.
c. Set Run Mode to 1 (cleaning)
d. Read operational state and verify it is changed to 1 (running)
e. Set Run Mode to 1 (idle)
f. Read operational state and verify it is changed to 0 (stopped)
Commands after commissioning
Test for 3
a. Commission.
b. Read operational state and run mode and ensure both are 0.
c. Set Run Mode to 1 (cleaning)
d. Read operational state and verify it is changed to 1 (running)
e. Wait for 30 seconds
f. Read operational state and run mode and ensure both are 0.