Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NXP] Fix OTA Factory Data compilation #37703

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[NXP] Fix OTA Factory Data compilation #37703

wants to merge 3 commits into from

Conversation

andrei-menzopol
Copy link
Contributor

Description

The PLATFORM_FACTORY_DATA_PROVIDER_IMPL_HEADER macro is set in e different source_set (nxp_factory_data) than nxp_ota where it is used (that is OTAFactoryDataProcessor.cpp) so it doesn't compile.
However FactoryDataProviderImpl is not used in OTAFactoryDataProcessor.cpp so it can be removed.

Testing

  • gn gen -C out/debug --args="nxp_use_factory_data=true chip_enable_ota_requestor=false"
  • OTA FactoryData local testing

@andrei-menzopol
[nxp][platform][common] Remove FactoryDataProviderImpl header
f9d2058 
 The PLATFORM_FACTORY_DATA_PROVIDER_IMPL_HEADER macro is set in e different
 source_set (nxp_factory_data) than nxp_ota where it is used
 (OTAFactoryDataProcessor.cpp) so it doesn't compile.
 However FactoryDataProviderImpl is not used in OTAFactoryDataProcessor.cpp
 so it can be removed.

Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
@andrei-menzopol
[nxp][platform][mcxw71] Remove FactoryDataProviderImpl header
b8a2a1f 
  The PLATFORM_FACTORY_DATA_PROVIDER_IMPL_HEADER macro is set in e different
  source_set (nxp_factory_data) than nxp_ota where it is used
  (OTAFactoryDataProcessor.cpp) so it doesn't compile.
  However FactoryDataProviderImpl is not used in OTAFactoryDataProcessor.cpp
  so it can be removed.

Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
@andrei-menzopol andrei-menzopol requested a review from a team as a code owner February 21, 2025 11:21
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions github-actions bot added platform nxp NXP platform labels Feb 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

PR #37703: Size comparison from 06edeee to 1cae934

Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, esp32, linux, nrfconnect, nxp, qpg, stm32, telink, tizen)
platform target config section 06edeee 1cae934 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095140 1095140 0 0.0
RAM 94802 94802 0 0.0
bl702 lighting-app bl702+eth FLASH 651586 651586 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 827750 827750 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1060912 1060912 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892098 892098 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 974994 974994 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815268 815268 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824180 824180 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771048 771048 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755324 755324 0 0.0
RAM 113932 113932 0 0.0
efr32 lock-app BRD4187C FLASH 937968 937968 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 731776 731776 0 0.0
RAM 234772 234772 0 0.0
window-app BRD4187C FLASH 1030720 1030720 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581932 1581932 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1549958 1549958 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2649711 2649711 0 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 5921216 5921216 0 0.0
RAM 513712 513712 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5266218 5266218 0 0.0
RAM 221112 221112 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4624892 4624892 0 0.0
RAM 199816 199816 0 0.0
camera-app debug unknown 5424 5424 0 0.0
FLASH 4671672 4671672 0 0.0
RAM 194592 194592 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13300565 13300565 0 0.0
RAM 603392 603392 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11565129 11565129 0 0.0
RAM 603176 603176 0 0.0
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4450216 4450216 0 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4944 4944 0 0.0
FLASH 5569029 5569029 0 0.0
RAM 470400 470400 0 0.0
lighting-app debug+rpc+ui unknown 6152 6152 0 0.0
FLASH 5514305 5514305 0 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5392 5392 0 0.0
FLASH 4688328 4688328 0 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4728 4728 0 0.0
FLASH 4310508 4310508 0 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4440666 4440666 0 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2949020 2949020 0 0.0
RAM 143672 143672 0 0.0
tv-app debug unknown 5720 5720 0 0.0
FLASH 5907941 5907941 0 0.0
RAM 593832 593832 0 0.0
tv-casting-app debug unknown 5296 5296 0 0.0
FLASH 11471373 11471373 0 0.0
RAM 718656 718656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907668 907668 0 0.0
RAM 142323 142323 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901732 901732 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846272 846272 0 0.0
RAM 141251 141251 0 0.0
nxp contact k32w0+release FLASH 585184 585184 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600640 600640 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611156 611156 0 0.0
RAM 70164 70164 0 0.0
k32w1+release FLASH 685640 685640 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 749480 749480 0 0.0
RAM 67500 67500 0 0.0
qpg lighting-app qpg6105+debug FLASH 662156 662156 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620264 620264 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459800 459800 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 665004 665004 0 0.0
RAM 90728 90728 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622048 622048 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745188 745188 0 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753750 753750 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680820 680820 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709382 709382 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600562 600562 0 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788704 788704 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5076 5076 0 0.0
FLASH 1750772 1750772 0 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18981598 18981598 0 0.0
RAM 8305976 8305976 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doru91 doru91 doru91 approved these changes

Assignees
No one assigned
Labels
nxp NXP platform platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrei-menzopol @doru91 @restyled-commits