Align XML definition for WebRTC Provider Cluster with spec #37648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufengwangca
changed the title
|
PR #37648: Size comparison from 33aec35 to 8d10292 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@yufengwangca could you confirm this was (re-)generated via Alchemy rather than manual? I can see the alchemy header there, however no indicator if this was updated via alchemy or not... |
andy31415
requested changes
Feb 19, 2025
There was a problem hiding this comment.
I am unsure if this was generated via alchemy - since this has an alchemy header please keep generating via alchemy and mention so in the PR summary.
Right now I believe this may be a manual edit due to removal of an extra line and no update on the Git: entry in alchemy.
Yes, it was initially generated via Alchemy, but I couldn't apply it directly because some elements—such as the file name—did not comply with the Alchemy standard (it should be "web-rtc" rather than "webrtc"). I manually edited the generated version to incorporate all necessary changes and also removed the overly detailed descriptions of each element that came from the specification. |
yufengwangca
force-pushed
the
pr/rtc/provider
branch
from
8d10292 to
7efcdd7
Compare
|
PR #37648: Size comparison from 86e0b85 to 7efcdd7 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37648: Size comparison from 86e0b85 to b921c03 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/rtc/provider
branch
from
b921c03 to
5b9479c
Compare
|
PR #37648: Size comparison from e1ca08f to 5b9479c Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/rtc/provider
branch
from
5b9479c to
82256b2
Compare
|
PR #37648: Size comparison from 616e1bd to 82256b2 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Feb 20, 2025
joonhaengHeo
approved these changes
Feb 21, 2025
popovdg
pushed a commit
to popovdg/connectedhomeip
that referenced
this pull request
Feb 25, 2025
…hip#37648) * Align xml defination for WebRTC provider cluster with spec * Generate XML file from alchemy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align xml definition for WebRTC Provider Cluster with the latest spec. https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/WebRTC_Provider.adoc
The update was initially generated using Alchemy, but it requires following manual modifications:
Testing
Validated by CI