Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chef compilation failure on Mac due to #35429 #37631

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix Chef compilation failure on Mac due to #35429 #37631

merged 1 commit into from
Feb 18, 2025

Conversation

erwinpan1
Copy link
Contributor

Issue description

Chef compilation failure on MacOS caused by #35429

% ./chef.py -zbr -d rootnode_onofflight_bbs1b7IaOV -t linux
...
Building...
arm64
zsh:1: no matches found: --add-export-compile-commands=*
Traceback (most recent call last):
  File "/Users/erwinpan/matter/erwinpan1/master_20250218_fixing_mvd/examples/chef/./chef.py", line 1027, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/erwinpan/matter/erwinpan1/master_20250218_fixing_mvd/examples/chef/./chef.py", line 887, in main
    shell.run_cmd("gn gen --add-export-compile-commands=* out")
  File "/Users/erwinpan/matter/erwinpan1/master_20250218_fixing_mvd/examples/chef/stateful_shell.py", line 139, in run_cmd
    raise RuntimeError(
RuntimeError: Error. Nonzero return code.
Returncode: 1
Cmd: gn gen --add-export-compile-commands=* out

Testing

% ./chef.py -zbr -d rootnode_onofflight_bbs1b7IaOV -t linux
... (build successfully) ...

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 18, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  examples/chef/chef.py  34% smaller

@andy31415
Copy link
Contributor

fast tracking trivial change.

@andy31415 andy31415 merged commit 126c125 into project-chip:master Feb 18, 2025
67 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

PR #37631: Size comparison from 20b7637 to 2c06568

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 20b7637 2c06568 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095586 1095586 0 0.0
RAM 94890 94890 0 0.0
bl702 lighting-app bl702+eth FLASH 652030 652030 0 0.0
RAM 33617 33617 0 0.0
bl702+wifi FLASH 828194 828194 0 0.0
RAM 22325 22325 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061358 1061358 0 0.0
RAM 32269 32269 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892066 892066 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975438 975438 0 0.0
RAM 24736 24736 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815564 815564 0 0.0
RAM 120352 120352 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824192 824192 0 0.0
RAM 125360 125360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771336 771336 0 0.0
RAM 113820 113820 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755612 755612 0 0.0
RAM 114028 114028 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539050 539050 0 0.0
RAM 205208 205208 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572922 572922 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656685 656685 0 0.0
RAM 75420 75420 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676545 676545 0 0.0
RAM 78060 78060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676545 676545 0 0.0
RAM 78060 78060 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633469 633469 0 0.0
RAM 70488 70488 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616237 616237 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635873 635873 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635873 635873 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635733 635733 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655449 655449 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655449 655449 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612081 612081 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631941 631941 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631941 631941 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937712 937712 0 0.0
RAM 159916 159916 0 0.0
BRD4338a FLASH 731680 731680 0 0.0
RAM 234772 234772 0 0.0
window-app BRD4187C FLASH 1030304 1030304 0 0.0
RAM 128020 128020 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581862 1581862 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1549830 1549830 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2651323 2651323 0 0.0
RAM 111536 111536 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 5922668 5922668 0 0.0
RAM 513584 513584 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5267796 5267796 0 0.0
RAM 221464 221464 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4626504 4626504 0 0.0
RAM 200200 200200 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13290579 13290579 0 0.0
RAM 602864 602864 0 0.0
chip-tool-ipv6only arm64 unknown 22008 22008 0 0.0
FLASH 11314624 11314624 0 0.0
RAM 654640 654640 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11557787 11557787 0 0.0
RAM 602648 602648 0 0.0
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4451826 4451826 0 0.0
RAM 187416 187416 0 0.0
fabric-sync debug unknown 4944 4944 0 0.0
FLASH 5569989 5569989 0 0.0
RAM 470192 470192 0 0.0
lighting-app debug+rpc+ui unknown 6152 6152 0 0.0
FLASH 5515473 5515473 0 0.0
RAM 204272 204272 0 0.0
lock-app debug unknown 5392 5392 0 0.0
FLASH 4687240 4687240 0 0.0
RAM 191152 191152 0 0.0
ota-provider-app debug unknown 4728 4728 0 0.0
FLASH 4312148 4312148 0 0.0
RAM 180216 180216 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4442310 4442310 0 0.0
RAM 184704 184704 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2950332 2950332 0 0.0
RAM 144040 144040 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4043384 4043384 0 0.0
RAM 228504 228504 0 0.0
tv-app debug unknown 5720 5720 0 0.0
FLASH 5908885 5908885 0 0.0
RAM 593592 593592 0 0.0
tv-casting-app debug unknown 5296 5296 0 0.0
FLASH 11460701 11460701 0 0.0
RAM 717920 717920 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907640 907640 0 0.0
RAM 142411 142411 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901944 901944 0 0.0
RAM 124755 124755 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846256 846256 0 0.0
RAM 141339 141339 0 0.0
nxp contact k32w0+release FLASH 585152 585152 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600632 600632 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611460 611460 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685936 685936 0 0.0
RAM 48680 48680 0 0.0
lock mcxw71+release FLASH 749456 749456 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646836 1646836 0 0.0
RAM 211576 211576 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553604 1553604 0 0.0
RAM 208392 208392 0 0.0
light cy8ckit_062s2_43012 FLASH 1439276 1439276 0 0.0
RAM 197144 197144 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467492 1467492 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662444 662444 0 0.0
RAM 105220 105220 0 0.0
lock-app qpg6105+debug FLASH 620240 620240 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 460088 460088 0 0.0
RAM 141568 141568 0 0.0
telink bridge-app tl7218x FLASH 665304 665304 0 0.0
RAM 90828 90828 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621986 621986 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745488 745488 0 0.0
RAM 40496 40496 0 0.0
tl7218x FLASH 754050 754050 0 0.0
RAM 97632 97632 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680754 680754 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709316 709316 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600862 600862 0 0.0
RAM 138912 138912 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 789004 789004 0 0.0
RAM 96488 96488 0 0.0
tizen all-clusters-app arm unknown 5108 5108 0 0.0
FLASH 1752212 1752212 0 0.0
RAM 93484 93484 0 0.0
chip-tool-ubsan arm unknown 11496 11496 0 0.0
FLASH 18969150 18969150 0 0.0
RAM 8300200 8300200 0 0.0

@erwinpan1 erwinpan1 deleted the fix_gn_command_failed branch February 18, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 andy31415 approved these changes

@Alami-Amine Alami-Amine Alami-Amine approved these changes

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erwinpan1 @andy31415 @tcarmelveilleux @Alami-Amine