Fix conformance errors on robotic vacuum cleaner (RVC) app #37617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
|
|
PR #37617: Size comparison from 7c1d6f7 to 9c8ab04 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37617: Size comparison from a5971fa to 5c48b32 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36826. It also solves other conformance errors.
Workflow is as follows.
examples/rvc-app/rvc-common/rvc-app.zapwith zap-tool..matterfile with./scripts/tools/zap/generate.py examples/rvc-app/rvc-common/rvc-app.zap./scripts/build/build_examples.py --target darwin-arm64-rvc-no-ble-clang-boringssl build./scripts/tests/run_python_test.py --app ./out/darwin-arm64-rvc-no-ble-clang-boringssl/chip-rvc-app --factory-reset --app-args "--trace-to json:log" --script src/python_testing/TC_DeviceConformance.py --script-args "--qr-code MT:-24J0AFN00KA0648G00"Testing
Run command 4 above.