-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build time optimization #37433
Build time optimization #37433
Conversation
afed4dd
to
ed2e356
Compare
PR #37433: Size comparison from 35781e5 to ed2e356 Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, nrfconnect, nxp, qpg, stm32, telink, tizen)
|
ed2e356
to
065a90a
Compare
065a90a
to
c8e1550
Compare
PR #37433: Size comparison from 2cf6dd8 to c8e1550 Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, nxp, qpg, stm32, telink, tizen)
|
49eb455
to
bbccf31
Compare
@adigie could you share build time deltas in the PR summary? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Testing
section should contain information how we tested that this actually does what it claims (improve build times). Things still compiling is ok and will be checked by CI. However we also claim this makes builds faster, so we should figure out how much faster
@andy31415 I updated the description, could you take a look? |
bbccf31
to
0ca81e6
Compare
Move AttributesChangedListener and MarkAttributeDirty out of af-types.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Fix missing includes after changes in Accessors.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Fix missing includes after changes in Accessors.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Fix missing includes after changes in Accessors.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
0ca81e6
to
9762497
Compare
* Move some classes out of af-types.h Move AttributesChangedListener and MarkAttributeDirty out of af-types.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Remove dependency to cluster-objects.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Remove cluster-objects from chip_data_model.cmake Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Chef] Fix includes Fix missing includes after changes in Accessors.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Infineon] Fix includes Fix missing includes after changes in Accessors.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [Silabs] Fix includes Fix missing includes after changes in Accessors.h Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Add missing cluster-objects.h after changes from project-chip#37433. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Add missing cluster-objects.h after changes from #37433. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Changes
cluster-objects.h
inAccessors.h
cluster-objects.cpp
fromchip_data_model.cmake
This should improve build times.
Testing
Tested by building nrfconnect lock-app example. Build time improved by 5.69%.
Traces generated with
ninjatracing
: