[Darwin] MTRDevice _delegateExists cannot be called without holding lock

project-chip · Feb 19, 2025 · 81264d3 · 81264d3
1 parent 38cc24b
commit 81264d3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/darwin/Framework/CHIP/MTRDevice.mm b/src/darwin/Framework/CHIP/MTRDevice.mm
@@ -253,6 +253,12 @@ - (void)invalidate
     [self _cancelAllAttributeValueWaiters];
 }
 
+- (BOOL)delegateExists
+{
+    std::lock_guard lock(_lock);
+    return [self _delegateExists];
+}
+
 - (BOOL)_delegateExists
 {
     os_unfair_lock_assert_owner(&self->_lock);

diff --git a/src/darwin/Framework/CHIP/MTRDeviceController_XPC.mm b/src/darwin/Framework/CHIP/MTRDeviceController_XPC.mm
@@ -79,7 +79,7 @@ - (void)_updateRegistrationInfo
 
     for (NSNumber * nodeID in [self.nodeIDToDeviceMap keyEnumerator]) {
         MTRDevice * device = [self _deviceForNodeID:nodeID createIfNeeded:NO];
-        if ([device _delegateExists]) {
+        if ([device delegateExists]) {
             NSMutableDictionary * nodeDictionary = [NSMutableDictionary dictionary];
             MTR_REQUIRED_ATTRIBUTE(MTRDeviceControllerRegistrationNodeIDKey, nodeID, nodeDictionary)
 

diff --git a/src/darwin/Framework/CHIP/MTRDevice_Internal.h b/src/darwin/Framework/CHIP/MTRDevice_Internal.h
@@ -146,8 +146,12 @@ MTR_DIRECT_MEMBERS
 // Returns YES if any non-null delegates were found
 - (BOOL)_iterateDelegatesWithBlock:(void(NS_NOESCAPE ^ _Nullable)(MTRDeviceDelegateInfo * delegateInfo))block;
 
+// For subclasses to call while holding lock
 - (BOOL)_delegateExists;
 
+// For device controller or other objects to call
+- (BOOL)delegateExists;
+
 // Must be called by subclasses or MTRDevice implementation only.
 - (void)_delegateAdded:(id<MTRDeviceDelegate>)delegate;
 - (void)_delegateRemoved:(id<MTRDeviceDelegate>)delegate;