Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the references, classes don't show up in the filter search #717

Open
davepagurek opened this issue Mar 7, 2025 · 4 comments
Open

In the references, classes don't show up in the filter search #717

davepagurek opened this issue Mar 7, 2025 · 4 comments
Labels
Bug Something isn't working

Comments

@davepagurek
Copy link
Collaborator

Most appropriate sections of the p5.js website?

Reference

What is your operating system?

Mac OS

Web browser and version

Firefox 135

Actual Behavior

If I filter for "Element", p5.Element doesn't show up:

Image

Expected Behavior

It does exist, it's just a subcategory of DOM (at the bottom of this screenshot):

Image

We probably need to include subcategory names in the filtering.

Steps to reproduce

No response

Would you like to work on the issue?

Someone else is free to implement this!

@davepagurek davepagurek added the Bug Something isn't working label Mar 7, 2025
@swastikCommits
Copy link

I would like to work on this.

@Bhumika-00
Copy link

Hi @davepagurek, I'd love to work on this issue if it's still available! It seems like the filtering logic needs to include subcategory names to ensure elements like p5.Element appear in search results.

I can investigate the current filtering implementation and update it accordingly. Please let me know if I can proceed!

Looking forward to your response. 🚀

@krishna4040
Copy link

@davepagurek the filter bar searches for methods containing the search word not for titles, correct me if I am wrong, but if it were to search for titles as well it would be a completely new feature!

@Sujith-43
Copy link

You are correct @krishna4040 . It searches for only methods present in the classes, not sub-classes or sub-categories.
we have to change the logic of the search bar where it can searches for sub-categories or sub-classes as well.
If this issue is still available , I can implement this.
@davepagurek Would you assign this issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants