Refactor/remove warnings #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s div [] []), some exhaustive pattern matches, some deprecation fixes
RebeccaNowak
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes dozens of warnings mostly deprecations and FS3365 and FS3370,
The majority of warnings were things such as
div[] []vsdiv [] []and mostly syntactical. There is still a lot of warnungs, mostly deprecatedWebClientand some more complex refactorings, i would rather perform in a separate PR.@RebeccaNowak or @LauraFritz14 could you quickly skim through the change-set if you find something problematic?