Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header tags don't update when document data does #43

Open
reefdog opened this issue Jun 20, 2019 · 0 comments
Open

Header tags don't update when document data does #43

reefdog opened this issue Jun 20, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@reefdog
Copy link

reefdog commented Jun 20, 2019

We just added document title/description editing in #6. However, the page <head> is composed statically without tying into state, so they don't update when the new document data is saved. The <meta> tags are invisible to the user, but the <title> (which has the document name in the window/tab title) is visible, and becomes stale until the page is re-rendered.

We need to either pass a title-updating function down to the document (gross) or add state to the page, or… something.
@reefdog reefdog added the bug Something isn't working label Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reefdog