Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor toast messages and add rerouting info #622

Merged
merged 8 commits into from
Jun 26, 2024
Merged

Refactor toast messages and add rerouting info #622

merged 8 commits into from
Jun 26, 2024

Conversation

PhilippMatthes
Copy link
Member

If available, link to the ticket

Closes: #

QA Checklist

Author

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Reviewer

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

PaulPickhardt
PaulPickhardt approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@PaulPickhardt PaulPickhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 2 bugs and tested this PR for iOS and android. Also checked battery consumption for rerouting. Looks good!

@PhilippMatthes PhilippMatthes merged commit f4fe14d into dev Jun 26, 2024
1 check passed
@PhilippMatthes PhilippMatthes deleted the refactor-toast-messages-and-add-rerouting-info branch June 26, 2024 13:23
@PaulPickhardt PaulPickhardt mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPickhardt PaulPickhardt PaulPickhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippMatthes @PaulPickhardt